Skip to content

Commit

Permalink
Prep DWDS for next release (24.2.0-wip) and get presubmit checks work…
Browse files Browse the repository at this point in the history
…ing again (#2485)

* Prep DWDS for next release (24.2.0-wip)

* [DWDS] Make TestContext.setUp set the --disable-gpu Chrome option when launching Chrome

* [DWDS] Skip frontend_server_ddc_and_canary_evaluate_test.dart

* [webdev] Skip cases in webdev/test/e2e_test.dart that are failing on Windows

---------

Co-authored-by: Derek Xu <[email protected]>
  • Loading branch information
bkonyi and derekxu16 authored Sep 4, 2024
1 parent 45df1cc commit 3deaa0c
Show file tree
Hide file tree
Showing 8 changed files with 568 additions and 553 deletions.
2 changes: 2 additions & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 24.2.0-wip

## 24.1.0

- Fix bug where debugging clients are not aware of service extensions when connecting to a new web app. - [#2388](https://github.com/dart-lang/webdev/pull/2388)
Expand Down
5 changes: 2 additions & 3 deletions dwds/lib/src/debugging/instance.dart
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,8 @@ class InstanceHelper extends Domain {
objectId,
offset: offset,
count: count,
length: metaData.kind != InstanceKind.kPlainInstance
? metaData.length
: null,
length:
metaData.kind != InstanceKind.kPlainInstance ? metaData.length : null,
);

final dartProperties = await _dartFieldsFor(properties, remoteObject);
Expand Down
Loading

0 comments on commit 3deaa0c

Please sign in to comment.