Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove mention of concrete variables, simplify rules around variable augmentation #3333

Merged
merged 1 commit into from
Sep 8, 2023
Merged

remove mention of concrete variables, simplify rules around variable augmentation #3333

merged 1 commit into from
Sep 8, 2023

Conversation

jakemac53
Copy link
Contributor

Per our conversation today, this:

  • Removes all mention of concrete variables.
  • Augmenting with a variable now only ever means augmenting the initializer of the augmented variable.
  • Disallow augmenting external and abstract variables with variables.

@jakemac53
Copy link
Contributor Author

Going to go ahead and merge this, but @munificent if you have any comments I will follow up, or revert, as needed :).

@jakemac53 jakemac53 merged commit b7e86ca into main Sep 8, 2023
3 checks passed
@jakemac53 jakemac53 deleted the fields-clarification branch September 8, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheglov scheglov scheglov approved these changes

@munificent munificent Awaiting requested review from munificent

Assignees
No one assigned
Labels
augmentation-libraries
Projects
Static Metaprogramming - design/prototype
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakemac53 @scheglov