Clarify that an extension type _can_ have instance variables which are external #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instance variables
This was referenced Aug 23, 2023
jakemac53
approved these changes
Aug 23, 2023
|
Thanks! |
lrhn
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current rule about instance variable declarations in an extension type declaration is that every instance variable declaration is a compile-time error (we only allow the implicitly induced instance variable which is caused by the parameter declaration in the primary constructor which is now syntactically the
<representationDeclaration>, because we don't yet have primary constructors).However, it is not an error to declare an external getter and/or setter, and an
externalinstance variable declaration is just a convenient notation for exactly that.This PR just clarifies that an external instance variable is not an error.
Fixes #3301.