Merge pull request #135 from dart-lang/merge-crypto-package

Merge `package:crypto`

.github/labeler.yml

@@ -4,6 +4,10 @@
   - changed-files:
       - any-glob-to-any-file: 'pkgs/args/**'
 
+"package:crypto":
+  - changed-files:
+      - any-glob-to-any-file: 'pkgs/crypto/**'
+
 "package:fixnum":
   - changed-files:
       - any-glob-to-any-file: 'pkgs/fixnum/**'

.github/workflows/crypto.yaml

@@ -0,0 +1,77 @@
+name: package:crypto
+
+on:
+  # Run CI on pushes to the main branch, and on PRs against main.
+  push:
+    branches: [ main ]
+    paths:
+      - '.github/workflows/crypto.yaml'
+      - 'pkgs/crypto/**'
+  pull_request:
+    branches: [ main ]
+    paths:
+      - '.github/workflows/crypto.yaml'
+      - 'pkgs/crypto/**'
+  schedule:
+    - cron: "0 0 * * 0"
+env:
+  PUB_ENVIRONMENT: bot.github
+
+defaults:
+  run:
+    working-directory: pkgs/crypto/
+
+jobs:
+  # Check code formatting and static analysis on a single OS (linux)
+  # against Dart dev.
+  analyze:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        sdk: [dev]
+    steps:
+      - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+      - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
+        with:
+          sdk: ${{ matrix.sdk }}
+      - id: install
+        name: Install dependencies
+        run: dart pub get
+      - name: Check formatting
+        run: dart format --output=none --set-exit-if-changed .
+        if: always() && steps.install.outcome == 'success'
+      - name: Analyze code
+        run: dart analyze --fatal-infos
+        if: always() && steps.install.outcome == 'success'
+
+  # Run tests on a matrix consisting of two dimensions:
+  # 1. OS: ubuntu-latest, (macos-latest, windows-latest)
+  # 2. release channel: dev
+  test:
+    needs: analyze
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        # Add macos-latest and/or windows-latest if relevant for this package.
+        os: [ubuntu-latest]
+        sdk: [3.4, dev]
+    steps:
+      - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+      - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
+        with:
+          sdk: ${{ matrix.sdk }}
+      - id: install
+        name: Install dependencies
+        run: dart pub get
+      - name: Run VM tests
+        run: dart test --platform vm
+        if: always() && steps.install.outcome == 'success'
+      - name: Run Chrome tests
+        run: dart test --platform chrome
+        if: always() && steps.install.outcome == 'success'
+      - name: Run Chrome tests - wasm
+        # TODO: investigate why we get hangs when concurrency is > 1
+        run: dart test --platform chrome --compiler dart2wasm -j 1
+        if: always() && steps.install.outcome == 'success'

README.md

@@ -9,6 +9,7 @@ This repository is home to various Dart packages under the [dart.dev](https://pu
 | Package | Description | Version |
 |---|---|---|
 | [args](pkgs/args/) | Library for defining parsers for parsing raw command-line arguments into a set of options and values. | [![pub package](https://img.shields.io/pub/v/args.svg)](https://pub.dev/packages/args) |
+| [crypto](pkgs/crypto/) | Implementations of SHA, MD5, and HMAC cryptographic functions. | [![pub package](https://img.shields.io/pub/v/crypto.svg)](https://pub.dev/packages/crypto) |
 | [fixnum](pkgs/fixnum/) | Library for 32- and 64-bit signed fixed-width integers. | [![pub package](https://img.shields.io/pub/v/fixnum.svg)](https://pub.dev/packages/fixnum) |
 
 ## Publishing automation

pkgs/crypto/.gitignore

@@ -0,0 +1,3 @@
+.dart_tool
+.packages
+pubspec.lock

pkgs/crypto/.test_config

@@ -0,0 +1,5 @@
+{
+  "test_package": {
+    "platforms": ["vm"]
+  }
+}

pkgs/crypto/AUTHORS

@@ -0,0 +1,6 @@
+# Below is a list of people and organizations that have contributed
+# to the project. Names should be added to the list like so:
+#
+#   Name/Organization <email address>
+
+Google Inc.

pkgs/crypto/CHANGELOG.md

@@ -0,0 +1,169 @@
+## 3.0.6
+
+* Move to `dart-lang/core` monorepo.
+
+## 3.0.5
+
+* Revert switch to enable fast "sinks" on Wasm because it breaks `dart2js` with
+  server mode.
+
+## 3.0.4
+
+* Fix WebAssembly support.
+* Require Dart 3.4
+
+## 3.0.3
+
+* Require Dart 2.19.0.
+* Add topics to `pubspec.yaml`.
+
+## 3.0.2
+
+* Require Dart 2.14.0.
+* Fix bug calculating hashes for content larger than 512MB when compiled to JS.
+
+## 3.0.1
+
+* Fix doc links in README.
+
+## 3.0.0
+
+* Stable release for null safety.
+* Adds SHA-2 512/224 and SHA-2 512/256 from FIPS 180-4
+* Removes `newInstance` instance members on some classes
+  and updates documentation.
+
+## 2.1.5
+
+* Improve example and package description to address package site maintenance
+  suggestions.
+
+## 2.1.4
+  * BugFix: padding was incorrect for some SHA-512/328.
+
+## 2.1.3
+  * **Security vulnerability**: Fixed constant-time comparison in `Digest`.
+
+## 2.1.2
+  * Fix bug in SHA-2 384/512 blocksize.
+  * Added HMAC-SHA-2 test vectors
+
+## 2.1.1+1
+  * Bump version number for publish mishap (spare file uploaded with `pub
+    publish`).
+
+## 2.1.1
+  * Added a workaround for a bug in DDC (used in build_web_compilers 1.x).
+  This bug is not present in DDK (used in build_web_compilers 2.x).
+
+## 2.1.0
+  * Added SHA384, and SHA512
+  * Add Sha224 + Refactor
+  * Support 32bit and 64bit operations for SHA384/51
+  * Add conditional imports
+  * De-listify 32bit allocations
+  * Add sha monte tests for 224,256,384, and 512
+
+## 2.0.5
+
+* Changed the max message size instead to 0x3ffffffffffff, which is the largest
+  portable value for both JS and the Dart VM.
+
+## 2.0.4
+
+* Made max message size a BigNum instead of an int so that dart2js can compile
+  with crypto.
+
+## 2.0.3
+
+* Updated SDK version to 2.0.0-dev.17.0
+
+## 2.0.2+1
+
+* Fix SDK constraint.
+
+## 2.0.2
+
+* Prepare `HashSink` implementation for limiting integers to 64 bits in Dart
+  language.
+
+## 2.0.1
+
+* Support `convert` 2.0.0.
+
+## 2.0.0
+
+**Note**: There are no APIs in 2.0.0 that weren't also in 0.9.2. Packages that
+would use 2.0.0 as a lower bound should use 0.9.2 instead—for example, `crypto:
+">=0.9.2 <3.0.0"`.
+
+* `Hash` and `Hmac` no longer extend `ChunkedConverter`.
+
+## 1.1.1
+
+* Properly close sinks passed to `Hash.startChunkedConversion()` when
+  `ByteConversionSink.close()` is called.
+
+## 1.1.0
+
+* `Hmac` and `Hash` now extend the new `ChunkedConverter` class from
+  `dart:convert`.
+
+* Fix all strong mode warnings.
+
+## 1.0.0
+
+* All APIs that were deprecated in 0.9.2 have been removed. No new APIs have
+  been added. Packages that would use 1.0.0 as a lower bound should use 0.9.2
+  instead—for example, `crypto: ">=0.9.2 <2.0.0"`.
+
+## 0.9.2+1
+
+* Avoid core library methods that don't work on dart2js.
+
+## 0.9.2
+
+* `Hash`, `MD5`, `SHA1`, and `SHA256` now implement `Converter`. They convert
+  between `List<int>`s and the new `Digest` class, which represents a hash
+  digest. The `Converter` APIs—`Hash.convert()` and
+  `Hash.startChunkedConversion`—should be used in preference to the old APIs,
+  which are now deprecated.
+
+* `SHA1`, `SHA256`, and `HMAC` have been renamed to `Sha1`, `Sha256`, and
+  `Hmac`, respectively. The old names still work, but are deprecated.
+
+* Top-level `sha1`, `sha256`, and `md5` fields have been added to make it easier
+  to use those hash algorithms without having to instantiate new instances.
+
+* Hashing now works correctly for input sizes up to 2^64 bytes.
+
+### Deprecations
+
+* `Hash.add`, `Hash.close`, and `Hash.newInstance` are deprecated.
+  `Hash.convert` should be used for hashing single values, and
+  `Hash.startChunkedConversion` should be used for hashing streamed values.
+
+* `SHA1` and `SHA256` are deprecated. Use the top-level `sha1` and `sha256`
+  fields instead.
+
+* While the `MD5` class is not deprecated, the `new MD5()` constructor is. Use
+  the top-level `md5` field instead.
+
+* `HMAC` is deprecated. Use `Hmac` instead.
+
+* `Base64Codec`, `Base64Encoder`, `Base64Decoder`, `Base64EncoderSink`,
+  `Base64DecoderSink`, and `BASE64` are deprecated. Use the Base64 APIs in
+  `dart:convert` instead.
+
+* `CryptoUtils` is deprecated. Use the Base64 APIs in `dart:convert` and the hex
+  APIs in the `convert` package instead.
+
+## 0.9.1
+
+* Base64 convert returns an Uint8List
+* Base64 codec and encoder can now take an encodePaddingCharacter
+* Implement a Base64 codec similar to codecs in 'dart:convert'
+
+## 0.9.0
+
+* ChangeLog starts here.

pkgs/crypto/LICENSE

@@ -0,0 +1,27 @@
+Copyright 2015, the Dart project authors.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are
+met:
+
+    * Redistributions of source code must retain the above copyright
+      notice, this list of conditions and the following disclaimer.
+    * Redistributions in binary form must reproduce the above
+      copyright notice, this list of conditions and the following
+      disclaimer in the documentation and/or other materials provided
+      with the distribution.
+    * Neither the name of Google LLC nor the names of its
+      contributors may be used to endorse or promote products derived
+      from this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.