Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2979. Update existing and add new tests checking nnbd static errors #2984

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of comments!

LanguageFeatures/nnbd/static_errors_A07_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/nnbd/static_errors_A07_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/nnbd/static_errors_A07_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/nnbd/static_errors_A07_t02.dart Outdated Show resolved Hide resolved
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptions updated. PTAL

LanguageFeatures/nnbd/static_errors_A07_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/nnbd/static_errors_A07_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/nnbd/static_errors_A07_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/nnbd/static_errors_A07_t02.dart Outdated Show resolved Hide resolved
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit ab5502e into dart-lang:master Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants