Skip to content

Commit

Permalink
Picker rework
Browse files Browse the repository at this point in the history
- Replace (most) references to "color pickers" with plain "pickers"
- Link pickers to central reference point
  • Loading branch information
elstoc committed Dec 7, 2024
1 parent 53100da commit 00d38e6
Show file tree
Hide file tree
Showing 25 changed files with 62 additions and 69 deletions.
7 changes: 3 additions & 4 deletions content/darkroom/masking-and-blending/masks/parametric.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ In this state a range select function selects the whole range of values giving a

Conversely a range de-select function (enabled by toggling the polarity) by default deselects the whole range of values, giving an “all-zero” mask as a starting point. Moving the sliders inwards gradually includes more and more parts of the image except for the remaining narrow range.

# color pickers
# pickers

With the left-hand color picker button you can select a point or area probe from your image. The corresponding values for the real and virtual data channels are then displayed within each color channel slider.
With the left-hand [picker](../../processing-modules/module-controls.md#pickers) button you can select a point or area probe from your image. The corresponding values for the real and virtual data channels are then displayed within each color channel slider.

With the right-hand color picker button you can automatically set the slider's values based on the selected range. Click and drag to set the parameters for the input slider from the drawn rectangle; Ctrl+click and drag to set the parameters for the output slider.
With the right-hand picker button you can automatically set the slider's values based on the selected range. Click and drag to set the parameters for the input slider from the drawn rectangle; Ctrl+click and drag to set the parameters for the output slider.

# invert

Expand All @@ -82,4 +82,3 @@ Click the invert button above the sliders to invert the polarity of the entire p
# reset

Click the reset button above the sliders to revert all parametric mask parameters to their default state.

4 changes: 2 additions & 2 deletions content/darkroom/processing-modules/module-controls.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ Click on a combobox to show a list of available options which you can click to s

As with sliders, you can double-click the combobox or its label to reset back to the default value, or Ctrl+double-click to reset back to any auto-applied preset.

# color pickers
# pickers

A number of modules allow parameters to be set using color pickers (identified by the ![color-picker-icon](./module-controls/color-picker.png#icon) icon). These use a standard interface and most can operate in either point or area mode. Point mode can be activated by clicking on the color picker icon. Area mode is activated with Ctrl+click or right-click.
A number of modules allow parameters to be set using pickers (identified by the ![picker-icon](./module-controls/color-picker.png#icon) icon). These use a standard interface and most can operate in either point or area mode. Point mode can be activated by clicking on the picker icon. Area mode is activated with Ctrl+click or right-click.

# keyboard shortcuts

Expand Down
2 changes: 1 addition & 1 deletion content/guides-tutorials/batch-editing.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ If there was some variability in your lighting conditions, each image will need

First, homogenize the exposure using your control sample and the [_area exposure mapping_](../module-reference/processing-modules/exposure.md#area-exposure-mapping) tool.

Then, adjust the _filmic rgb_ white relative exposure if needed, preferably using the color picker. The contrast should not require any adjustment since it does not depend on the dynamic-range of the image.
Then, adjust the _filmic rgb_ white relative exposure if needed, preferably using the [picker](../darkroom/processing-modules/module-controls.md#pickers). The contrast should not require any adjustment since it does not depend on the dynamic-range of the image.

Finally, homogenize the chromatic adaptation, using your control sample and the [_color calibration area mapping_](../module-reference/processing-modules/color-calibration.md#area-color-mapping) tool.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ vibrance
: Accentuate the colors of the image without adding unnatural colors, as it's often the case with the _saturation_ slider. It works by reducing the lightness of already saturated pixels to make the colors more vivid. You can also achieve some interesting effects by combining it with the saturation slider to target more or less saturated areas of the image.

auto
: Automatically adjust the exposure, taking into account the entire image, or use the color picker to select a rectangular area of the image -- the exposure will be automatically adjusted based on the selected region. This allows you to prioritise which parts of the image should be well-exposed.
: Automatically adjust the exposure, taking into account the entire image, or use the [picker](../../darkroom/processing-modules/module-controls.md#pickers) to select a rectangular area of the image -- the exposure will be automatically adjusted based on the selected region. This allows you to prioritise which parts of the image should be well-exposed.

clip
: This affects the number of pixels that will be clipped to black or white during the auto-exposure calculation. Moving this slider to the right will allow more pixels to be clipped and increase the contrast; moving this slider to the left will compress the image more and lower the contrast.

Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Each of the settings in the 4 ways tab is composed of the same three components,

Color input like this defines a color shift applied to the image globally or over the specified luminance range.

Each hue slider has a color picker, which may be used to compute the opponent color of the selected region. This is useful to revert unwanted color casts (e.g. skin redness), since shifting the color to its opponent cast neutralizes it.
Each hue slider has a [picker](../../darkroom/processing-modules/module-controls.md#pickers), which may be used to compute the opponent color of the selected region. This is useful to revert unwanted color casts (e.g. skin redness), since shifting the color to its opponent cast neutralizes it.

### global offset

Expand Down Expand Up @@ -132,12 +132,12 @@ Luminance masks are computed at the input of the module, which means that they a
white fulcrum
: Set the white point luminance in EV. This is used to normalize the _power_ setting in the [_4 ways_](#4-ways-tab) tab. Display-referred implementations of power functions assume that white is at 100%, which removes the need for normalization. For scene-referred purposes this needs to be taken into account.

: The color picker to the right of the slider automatically sets the white fulcrum to the maximum luminance from the selected region, which should be sufficient in most cases.
: The [picker](../../darkroom/processing-modules/module-controls.md#pickers) to the right of the slider automatically sets the white fulcrum to the maximum luminance from the selected region, which should be sufficient in most cases.

contrast gray fulcrum
: Set the fulcrum for the _contrast_ setting in the [_master_](#master-tab) tab. This corresponds to the luminance value that will be left unchanged by the contrast adjustment. This setting usually matches the middle-gray linear value. If you followed the scene-referred workflow recommendations and set the global brightness early in the pipeline, using the _exposure_ module, the correct value should usually be around 18-20%.

: The color picker to the right of the slider automatically sets the contrast gray fulcrum to the average luminance from the selected region. This relies on the assumption that the average luminance is usually close to middle-gray, which is not true if you have specular highlights or primary light sources in the frame, or for low/high-key images.
: The [picker](../../darkroom/processing-modules/module-controls.md#pickers) to the right of the slider automatically sets the contrast gray fulcrum to the average luminance from the selected region. This relies on the assumption that the average luminance is usually close to middle-gray, which is not true if you have specular highlights or primary light sources in the frame, or for low/high-key images.

### saturation formula

Expand Down
10 changes: 5 additions & 5 deletions content/module-reference/processing-modules/color-balance.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,19 +81,19 @@ shadows, mid-tones, highlights
---

optimize luma
: The color picker beside the optimize luma label will select the whole image and optimize the factors for shadows, mid-tones and highlights so that the average luminance of the image is 50% Lab, the maximum is 100% and the minimum is 0%, at the output of this module. This is essentially histogram normalization, similar to that performed by the [_levels_](./levels.md) module. The optimizer is only really accurate when used in _slope, offset, power_ mode.
: The [picker](../../darkroom/processing-modules/module-controls.md#pickers) beside the optimize luma label will select the whole image and optimize the factors for shadows, mid-tones and highlights so that the average luminance of the image is 50% Lab, the maximum is 100% and the minimum is 0%, at the output of this module. This is essentially histogram normalization, similar to that performed by the [_levels_](./levels.md) module. The optimizer is only really accurate when used in _slope, offset, power_ mode.

: If you want more control, you can define three control patches by using the color pickers beside each factor slider to sample luminance in selected areas. The _shadows_ color picker samples the minimum luminance, the _mid-tones_ color picker samples the average luminance, and the _highlights_ color picker samples the maximum luminance. The most sensitive parameter is the mid-tones factor, since selecting a slightly different area can lead to dramatic parameter changes. Using the factors color pickers alone, without triggering the luma optimization, will allow you to perform adjustments without general optimization, but each parameter is always computed taking the other two into account. Once patches are selected, the label changes to read “optimize luma from patches”. To reset one patch, you can just redo the selection. Patches are not saved in the parameters and are retained only during the current session.
: If you want more control, you can define three control patches by using the pickers beside each factor slider to sample luminance in selected areas. The _shadows_ picker samples the minimum luminance, the _mid-tones_ picker samples the average luminance, and the _highlights_ picker samples the maximum luminance. The most sensitive parameter is the mid-tones factor, since selecting a slightly different area can lead to dramatic parameter changes. Using the factors pickers alone, without triggering the luma optimization, will allow you to perform adjustments without general optimization, but each parameter is always computed taking the other two into account. Once patches are selected, the label changes to read “optimize luma from patches”. To reset one patch, you can just redo the selection. Patches are not saved in the parameters and are retained only during the current session.

: It is important to note that the luminance adjustment targets only the output of the _color balance_ module and does not account for adjustments performed in other modules later in the pixelpipe (e.g. [_filmic rgb_](./filmic-rgb.md), [_tone curve_](./tone-curve.md), [_color zones_](./color-zones.md), [_levels_](./levels.md)). Using the _color balance_ module to remap the luminance globally on the image is not recommended because it does not preserve the original colors -- modules such as [_tone curve_](./tone-curve.md) or [_filmic rgb_](./filmic-rgb.md) are better suited for this purpose. Luminance adjustments in _color balance_ are better performed, in combination with color adjustments, using masks.

neutralize colors
: In an image where some areas are exposed to direct sunlight and some areas are exposed to reflected light (shadows), or where several artificial light sources are present simultaneously, shadows and highlights often have different color temperatures. These images are particularly difficult to correct since no general white balance will match all the colors at once. The color neutralization optimizer aims at helping you find the complementary color for shadows, mid-tones, and highlights so that all the color casts are reverted, and the average color of the image is a neutral gray.

: As with the luma optimization, the color picker beside the neutralize colors label will trigger a general optimization over the whole image. This works fairly well in landscape photography, or for any photograph with a full spectrum of colors and luminances.
: As with the luma optimization, the [picker](../../darkroom/processing-modules/module-controls.md#pickers) beside the neutralize colors label will trigger a general optimization over the whole image. This works fairly well in landscape photography, or for any photograph with a full spectrum of colors and luminances.

: For night and events photography, this will most likely fail and you will need to manually input the sampling areas with the color pickers beside each hue slider. For the highlights sample, use a color exposed to spotlights that should be neutral white or light gray. For the shadows sample, use a color exposed to ambient light that should be neutral black or dark gray. For the mid-tones sample, use a color exposed by both ambient and spotlights.
: For night and events photography, this will most likely fail and you will need to manually input the sampling areas with the picker beside each hue slider. For the highlights sample, use a color exposed to spotlights that should be neutral white or light gray. For the shadows sample, use a color exposed to ambient light that should be neutral black or dark gray. For the mid-tones sample, use a color exposed by both ambient and spotlights.

: The success of the optimization depends on the quality of the samples. Not every set of samples will converge to a good solution and you need to ensure that the color patches you choose are really a neutral color in real life. In many cases the optimizer will output the correct hue but an excessive saturation that will need some extra tweaking. In some cases, no valid optimization will be delivered and you will need to reset the saturation parameters and start over, or simply stop after the patches selection. Note that in the auto-optimization, the maximum saturation is 25%, which might not be enough in very few cases but will avoid inconsistent results in most.

: If you select color patches from the hue color pickers without triggering the optimization, the software will only perform one round of optimization and then stop. This allows you to control each luminance range separately and avoid divergence of the solution in corner cases. The hue and saturation corrections are computed taking into account the two other luminance ranges and three factors, and will always output the complementary color of the selected area. If you want to reinforce the color of the area instead, you can then add 180° to the computed hue. Once patches are selected, the label changes to read “neutralize colors from patches”. To reset one patch you can just redo the selection. Patches are not saved in the parameters and are retained only during the current session. The parameters found by the automatic neutralization are accurate only in _slope, offset, power_ mode, but can work to some extent in _lift, gamma, gain_ mode too.
: If you select color patches from the hue pickers without triggering the optimization, the software will only perform one round of optimization and then stop. This allows you to control each luminance range separately and avoid divergence of the solution in corner cases. The hue and saturation corrections are computed taking into account the two other luminance ranges and three factors, and will always output the complementary color of the selected area. If you want to reinforce the color of the area instead, you can then add 180° to the computed hue. Once patches are selected, the label changes to read “neutralize colors from patches”. To reset one patch you can just redo the selection. Patches are not saved in the parameters and are retained only during the current session. The parameters found by the automatic neutralization are accurate only in _slope, offset, power_ mode, but can work to some extent in _lift, gamma, gain_ mode too.
Loading

0 comments on commit 00d38e6

Please sign in to comment.