Skip to content

Commit

Permalink
Don't exit with not implemented error on latch clock data
Browse files Browse the repository at this point in the history
Since RTC is not implemented yet but some games that use RTC still work
without a full implementation (such as Pokemon) it is better to just
issue a warning here as a reminder instead of refusing to work.
  • Loading branch information
dariusarnold committed Mar 12, 2023
1 parent 7b98f18 commit d78ee0a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/game-boy-emulator/mbc3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void Mbc3::write_registers(uint16_t address, uint8_t value) {
}
} else if (memmap::is_in(address, memmap::BankingModeSelect)) {
// Latch clock data if previous write was 0x0 and this write was 0x1
throw NotImplementedError("Unimplemented: Latch clock data");
get_logger()->warn("Latch clock data not implemented");
}
// get_logger()->debug("Cartridge registers: RAMG {}, BANK1 {:05B}, BANK2 {:02b}, MODE
// {:1B}",
Expand Down

0 comments on commit d78ee0a

Please sign in to comment.