Added mechanism for importing certificates found in /data/ssl #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An ENTRYPOINT named start-java.sh was added to the Dockerfile
- The ENTRYPOINT calls the import-certs.sh script before calling
the COMMAND (argument of docker run) or CMD (defined in Dockerfile)
- The import-certs.sh script uses the keytool to import any
certificates it can find inside /data/ssl
- Example: docker run -v"$(pwd)"/sample-certs:/data/ssl \
--rm mcreations/openwrt-java
Docker images which are based on this one and define a CMD but no
ENTRYPOINT will have any certificates mounted in /data/ssl
imported automatically.
Docker images which are based on this one and define an ENTRYPOINT
will override the start-java.sh ENTRYPOINT and thus will not have
certificates loaded. For this case, there exist the alternatives:
- Change ENTRYPOINT to CMD if possible
- Change the ENTRYPOINT script to call /usr/local/bin/import-certs.sh
directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the COMMAND (argument of docker run) or CMD (defined in Dockerfile)
certificates it can find inside /data/ssl
--rm mcreations/openwrt-java
Docker images which are based on this one and define a CMD but no
ENTRYPOINT will have any certificates mounted in /data/ssl
imported automatically.
Docker images which are based on this one and define an ENTRYPOINT
will override the start-java.sh ENTRYPOINT and thus will not have
certificates loaded. For this case, there exist the alternatives:
directly