/events: Move WithClock to unit build tagged file

[JoshVanL]

Reverts #62

WithClock should be moved to unit build tagged files to not pollute implementation non-test builds. Developers wanting to override the clock in testing can do so by go testing with the unit build tag.

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a043330). Click here to learn what that means.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage        ?   81.05%           
=======================================
  Files           ?       40           
  Lines           ?     2328           
  Branches        ?        0           
=======================================
  Hits            ?     1887           
  Misses          ?      317           
  Partials        ?      124           

Files	Coverage Δ
events/batcher/batcher.go	87.50% <ø> (ø)
events/batcher/unit.go	100.00% <100.00%> (ø)
events/queue/processor.go	90.21% <100.00%> (ø)
events/queue/processor_unit.go	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ItalyPaleAle]

#62 was made on purpose. Please don’t reverse this.

[JoshVanL]

#62 was made on purpose. Please don’t reverse this.

I don't see the technical reason for needing WithClock in the implementation code. The mock code is still available in tests with the unit build tag.

[yaron2]

@JoshVanL please resolve the conflict

[JoshVanL]

@yaron2 Done

[yaron2]

#62 was made on purpose. Please don’t reverse this.

I don't see the technical reason for needing WithClock in the implementation code. The mock code is still available in tests with the unit build tag.

@ItalyPaleAle please review this comment so we can decide how to move forward with this PR