Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 3.4.0-rc.2 for final release test #618

Merged
merged 10 commits into from
Aug 17, 2024

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Aug 15, 2024

Description

  • updated release version to 3.4.0-rc.2 in package.json
  • ran npm install to refreshen build and lock files
  • updated and ran ./scripts/fetch-proto.sh with protos set to dapr v1.14.0 (the final release)
  • updated .github/workflows/test-e2e.yml with final Dapr 1.14.0 runtime and CLI versions

Reverse engineered this using:

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

bondz and others added 6 commits July 31, 2024 08:11
Update AbstractActor.ts

Signed-off-by: Bond <[email protected]>
Update README.md

Signed-off-by: Joe Bowbeer <[email protected]>
Update README.md

Signed-off-by: greenie-msft <[email protected]>
* use dapr 1.14.0-rc.6

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Version correction

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Update .github/workflows/test-e2e.yml

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

---------

Signed-off-by: Deepanshu Agarwal <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
@paulyuk paulyuk added the P0 label Aug 15, 2024
@paulyuk paulyuk added this to the Dapr Node.js SDK - v3.4.0 milestone Aug 15, 2024
@paulyuk paulyuk self-assigned this Aug 15, 2024
@paulyuk paulyuk requested review from a team as code owners August 15, 2024 00:20
@paulyuk
Copy link
Contributor Author

paulyuk commented Aug 15, 2024

@DeepanshuA need your help with this error. Did I need to run build-grpc.sh? I didn't like what it generated, seemed like noops to methods.
https://github.com/dapr/js-sdk/actions/runs/10396671348/job/28791108591?pr=618#step:14:867

/assign @DeepanshuA

@paulyuk paulyuk changed the base branch from main to bump_3_4_0_rc_1 August 17, 2024 20:27
@paulyuk paulyuk changed the base branch from bump_3_4_0_rc_1 to bump_3_4_0_rc_2 August 17, 2024 23:25
@paulyuk paulyuk changed the title Bump to 3.4.0 for final release Bump to 3.4.0-rc.2 for final release test Aug 17, 2024
Copy link
Contributor Author

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as prior PR

@paulyuk paulyuk merged commit 3a3a1a8 into dapr:bump_3_4_0_rc_2 Aug 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

5 participants