Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1239 remove polyfill packages #1258

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

thompson-tomo
Copy link
Contributor

Description

Have removed the polyfill packages as they are being provided by the framework hence explicit dependency is not needed.

Issue reference

Closes #1239

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly

@thompson-tomo thompson-tomo requested review from a team as code owners March 30, 2024 09:09
Signed-off-by: James Thompson - SkiData <[email protected]>
@thompson-tomo thompson-tomo force-pushed the chore/#1239_PackageCleanup branch from 1056ba3 to 2c4fc91 Compare March 30, 2024 09:10
Copy link
Collaborator

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@philliphoff philliphoff merged commit ad3350f into dapr:master Apr 8, 2024
10 checks passed
@thompson-tomo thompson-tomo deleted the chore/#1239_PackageCleanup branch April 8, 2024 19:51
@marcduiker
Copy link
Contributor

@holopin-bot @thompson-tomo Thank you!

Copy link

holopin-bot bot commented Apr 24, 2024

Congratulations @thompson-tomo, you just earned a badge! Here it is: https://holopin.io/claim/clvdvma3761860gjilnz8h1s8

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@philliphoff philliphoff added this to the v1.14 milestone Jul 23, 2024
divzi-p pushed a commit to divzi-p/dotnet-sdk that referenced this pull request Dec 10, 2024
Signed-off-by: James Thompson - SkiData <[email protected]>
Co-authored-by: Phillip Hoff <[email protected]>
Signed-off-by: Divya Perumal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant dependencies
3 participants