-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aws): revamp aws docs + iam role anywhere profile #4456
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8e059a3
docs(aws): revamp aws docs + iam role anywhere profile
sicoyle f4c8ae8
style: clean up
sicoyle 4ca705b
style: add deprecation notices and clean up
sicoyle 2952bf3
fix: address feedback so far
sicoyle 642d565
Merge branch 'v1.15' into feat-iam-roles-anywhere
hhunter-ms e9f742e
style: rm numbers on titles
sicoyle aa51785
Merge branch 'feat-iam-roles-anywhere' of github.com:sicoyle/docs int…
sicoyle 27c401e
style: last few tweaks
sicoyle 5c402f6
Merge branch 'v1.15' into feat-iam-roles-anywhere
msfussell afdc4ea
style: update version to include the v prefix
sicoyle cae4e10
Merge branch 'v1.15' into feat-iam-roles-anywhere
hhunter-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment correct about Dapr v1.17? Do you mean v1.16 the next release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msfussell I left a comment about this too - here's @sicoyle's response: #4456 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, so it's 1.17 bc we're deprecating all aws prefixed fields. So, I've marked accessKey and secretKey as not required to help support the transition, so the docs are denoted and the metadata bundle as well to state that it will be required in dapr 1.17 as we rm the duplicate fields that had the aws prefix, and then the accessKey and secretKey fields can become required again.