Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instructions to open the .dapr folder in the user profile on Windows #3983

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Add instructions to open the .dapr folder in the user profile on Windows #3983

merged 5 commits into from
Feb 1, 2024

Conversation

prashantrewar
Copy link
Contributor

@prashantrewar prashantrewar commented Jan 27, 2024 •
edited
Loading

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

Fixes #3939

@prashantrewar prashantrewar requested review from a team as code owners January 27, 2024 13:59
msfussell
msfussell reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest being explicit with the commands with some text

daprdocs/content/en/getting-started/install-dapr-selfhost.md Outdated Show resolved Hide resolved
daprdocs/content/en/getting-started/install-dapr-selfhost.md Show resolved Hide resolved
msfussell
msfussell reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest being explicit with the commands with text

hhunter-ms
hhunter-ms requested changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just clarifying a bit

daprdocs/content/en/getting-started/install-dapr-selfhost.md Outdated Show resolved Hide resolved
daprdocs/content/en/getting-started/install-dapr-selfhost.md Outdated Show resolved Hide resolved
marcduiker
marcduiker previously requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@marcduiker marcduiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! It was missing a backslash (I did not include that when I created the issue).

daprdocs/content/en/getting-started/install-dapr-selfhost.md Outdated Show resolved Hide resolved
daprdocs/content/en/getting-started/install-dapr-selfhost.md Outdated Show resolved Hide resolved
prashantrewar and others added 5 commits February 1, 2024 17:42
@prashantrewar
Add instructions to open the .dapr folder in the user profile on Windows
fc48883 
Signed-off-by: Prashant Rewar <[email protected]>
@prashantrewar @hhunter-ms
Update daprdocs/content/en/getting-started/install-dapr-selfhost.md
e9a7a6f 
Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Prashant Rewar <[email protected]>
@prashantrewar @hhunter-ms
Update daprdocs/content/en/getting-started/install-dapr-selfhost.md
96cad2b 
Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Prashant Rewar <[email protected]>
@msfussell @marcduiker @prashantrewar
Update daprdocs/content/en/getting-started/install-dapr-selfhost.md
d88ccb6 
Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
@msfussell @marcduiker @prashantrewar
Update daprdocs/content/en/getting-started/install-dapr-selfhost.md
9a35e69 
Co-authored-by: Marc Duiker <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
@prashantrewar
Copy link
Contributor Author

Almost there! It was missing a backslash (I did not include that when I created the issue).

I updated the changes. Please take a look and suggest changes if required.

Thank you @msfussell, @hhunter-ms, and @marcduiker for your suggestion and guidance.

@hhunter-ms hhunter-ms dismissed marcduiker’s stale review February 1, 2024 15:27

this is resolved

@hhunter-ms hhunter-ms merged commit 4ee9d6d into dapr:v1.12 Feb 1, 2024
7 checks passed
@prashantrewar prashantrewar deleted the add-instructions branch February 2, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfussell msfussell Awaiting requested review from msfussell

@marcduiker marcduiker Awaiting requested review from marcduiker

@hhunter-ms hhunter-ms Awaiting requested review from hhunter-ms

Assignees

@prashantrewar prashantrewar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify instructions to open the .dapr folder in the user profile on Windows
4 participants
@prashantrewar @marcduiker @msfussell @hhunter-ms