Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .NET examples for encryption and decryption to Cryptography how-to #3947

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
    - [ ] Commands include options for Linux, MacOS, and Windows within codetabs N/A
    - [ ] New file and folder names are globally unique N/A
    - [ ] Page references use shortcodes instead of markdown or URL links N/A
    - [ ] Images use HTML style and have alternative text N/A
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This is a replacement PR for the one here since it oddly had a bunch of unrelated commits added.

Added examples and documentation reflecting the new .NET support for the cryptography building block. It can use additional examples for streaming, but I want to figure out a higher performing one that supports bidirectional reads and writes consistent with the API capabilities rather than the previous example I used.

Issue reference

Please don't accept this PR until this issue has been accepted and merged into the .NET SDK.

@WhitWaldo WhitWaldo requested review from a team as code owners January 11, 2024 10:41
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Jan 17, 2024
@msfussell msfussell added waiting-on-code-pr The code PR needs to be merged before the docs are updated and removed stale labels Jan 18, 2024
@msfussell msfussell added this to the 1.13 milestone Jan 22, 2024
@msfussell msfussell added the P1 label Jan 23, 2024
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code sample looks good. Just waiting on the code PR to now merge.

@hhunter-ms hhunter-ms removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Feb 14, 2024
@msfussell msfussell merged commit 40f9069 into dapr:v1.12 Feb 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants