Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change app protocol flag #3797

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Oct 7, 2023

migrated --app-ssl to --app-protocol https

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

dapr/cli#1269

As referenced in the above issue, the flag --app-ssl has been deprecated.

Issue reference

This will close #3794

@mikeee mikeee requested review from a team as code owners October 7, 2023 17:36
@msfussell
Copy link
Member

@mikeee - There is considerable formatting on these docs for spaces, which is not entirely necessary and makes it harder to follow. Can you remove these, unless it is syntactically incorrect (which I could not see). Thanks

@mikeee mikeee force-pushed the mikeee-remove-deprecated-flag branch from c722af3 to a64c7d8 Compare October 9, 2023 09:46
@mikeee
Copy link
Member Author

mikeee commented Oct 9, 2023

Pushed with formatting removed

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this contribution

@hhunter-ms hhunter-ms merged commit af4b793 into dapr:v1.12 Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants