Remove ethers from main #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmushegian
added a commit
that referenced
this pull request
May 16, 2022
* rearrange for mock deploys * buildweb * buildweb * clean * finalize * clean * force gh pages build * clean * Create CNAME * gardening * gardening * style * fix command * demo * Move cid (#112) * fix CID utils for lock location move CID utils to app lib uses release pack * update output Co-authored-by: stobiewan <[email protected]> * clean * trace walk * dont overwrite dmap with mock dmap * Remove ethers from main (#118) * use RPC calls in place of ethers in main.js * add address to dmap facade Co-authored-by: stobiewan <[email protected]> * Remove Ethers Dependencies (#117) * very rough utils file; replace BigNumber, toHexString, and hexZeroPad in dmap.js * no typescript; replace BigNumber, toHexString, hexZeroPad * replace keccak256 with base js-sha3 wrapper for strings * remove dependency on ethers abi encoder * homegrown calldata for funcs with bytes32 args; no more ethers for dmap * clean up utils file * consolidate * consolidate * fix tests for combined utils (#119) Co-authored-by: stobiewan <[email protected]> * cut ipfs http client (#120) Co-authored-by: stobiewan <[email protected]> * use infura if no node and no window.ethereum (#121) Co-authored-by: stobiewan <[email protected]> * cut buffer and first half of dependencies (#122) Co-authored-by: stobiewan <[email protected]> * readme * clean walk output * include address in page Co-authored-by: stobiewan <[email protected]> Co-authored-by: stobiewan <[email protected]> Co-authored-by: dmfxyz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the ethers removal component of #114 . CID functionality is untouched.
The provider is now an object which is compatible with an ethers contract for use in dmap.js, there's a few reasons for this. It means dmap.js can still work when used without the UI for stand alone usage or in tests, keeps this PR small, and makes merging with the other ethers branch easy by not touching dmap.js.
UI now works if at least one of window.ethereum, or the node at ethNode (configured for cors like --http.corsdomain '*') can respond with ethereum mainnet results.