Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backfill play tagline for NFT Catalog #180

Merged
merged 11 commits into from
Nov 16, 2022
Merged

Backfill play tagline for NFT Catalog #180

merged 11 commits into from
Nov 16, 2022

Conversation

zihehuang
Copy link
Contributor

@zihehuang zihehuang commented Nov 1, 2022 •
edited
Loading

This PR Addresses #167

What I changed

  • Added a tagline setter function to Play struct
  • Added an access function for Admin resource to backfill the play struct with taglines
  • Updated description to use the Play tagline if tagline exists

How is this tested

  • Added a test that asserts tagline being added to Play metadata

@zihehuang zihehuang force-pushed the zihe/9107/backfill-play-tagline branch 2 times, most recently from 6743777 to 23e7677 Compare November 1, 2022 20:50
@zihehuang zihehuang requested a review from jrkhan November 1, 2022 20:51
@zihehuang zihehuang marked this pull request as ready for review November 1, 2022 20:52
@zihehuang zihehuang requested a review from a team as a code owner November 1, 2022 20:53
@zihehuang zihehuang force-pushed the zihe/9107/backfill-play-tagline branch from 23e7677 to 3915a93 Compare November 1, 2022 20:53
@zihehuang zihehuang changed the title backfill play tagline for NFT Catalog Backfill play tagline for NFT Catalog Nov 1, 2022
jrkhan
jrkhan reviewed Nov 15, 2022
View reviewed changes
contracts/TopShot.cdc Outdated Show resolved Hide resolved
@jrkhan
Copy link
Contributor

jrkhan commented Nov 15, 2022

I believe the intent will be to remove the method that we use to backfill the tagline once it has been completed - it is being added temporarily.

@zihehuang zihehuang requested a review from jrkhan November 15, 2022 18:58
@zihehuang zihehuang force-pushed the zihe/9107/backfill-play-tagline branch from 3f83e14 to 3437ec5 Compare November 15, 2022 19:24
satyamakgec
satyamakgec reviewed Nov 16, 2022
View reviewed changes
Copy link

@satyamakgec satyamakgec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments

contracts/TopShot.cdc Outdated Show resolved Hide resolved
contracts/TopShot.cdc Outdated Show resolved Hide resolved
transactions/admin/update_tagline.cdc Outdated Show resolved Hide resolved
transactions/admin/update_tagline.cdc Outdated Show resolved Hide resolved
@zihehuang zihehuang force-pushed the zihe/9107/backfill-play-tagline branch from 8503f1f to 3a13f45 Compare November 16, 2022 18:36
jrkhan
jrkhan reviewed Nov 16, 2022
View reviewed changes
contracts/TopShot.cdc Outdated Show resolved Hide resolved
@zihehuang zihehuang force-pushed the zihe/9107/backfill-play-tagline branch from 0e285e8 to 1f12f73 Compare November 16, 2022 21:26
@zihehuang zihehuang requested a review from jrkhan November 16, 2022 21:26
@jrkhan jrkhan merged commit 8637e8b into master Nov 16, 2022
@jrkhan jrkhan deleted the zihe/9107/backfill-play-tagline branch November 16, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrkhan jrkhan jrkhan approved these changes

@satyamakgec satyamakgec Awaiting requested review from satyamakgec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zihehuang @jrkhan @satyamakgec