Add 'group()' built-in function to DaphneDSL. #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This built-in function creates a GroupOp in DaphneIR. - Only support 'SUM' as an aggregation function. - Get only one aggregation column. - Get an arbitrary number of columns to group on. - Add support for string values in the 'group' kernel function. - SUM, MIN, and MAX are the only aggregation functions applied to string columns. - Other aggregation functions throw an exception if they receive strings as arguments or results. - Additionally, 'DeduceValueTypeAndExecute' cannot handle string values due to unsupported operations on strings. - Therefore, 'ColumnGroupAggStringVTArg' that is specialized for strings is used. - Or 'ColumnGroupAgg' is called exclusively with string values. - The 'group' function internally calls the 'order' and 'extractCol' kernel functions. - These two functions are updated to handle string values correctly. - Added script-level test cases to validate the new functionality. - Close issue daphne-eu#903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
group()Built-in Function to DaphneDSL for Grouping and AggregationDescription
This pull request introduces a new
group()built-in function to DaphneDSL, enabling the creation of aGroupOpin DaphneIR and closes issue #903 .Changes Implemented
group()Built-in Function in DaphneDSL:group(arg:frame, groupCols:str, ..., sumCol:str)SUMas the aggregation function.Kernel Function Updates:
orderandextractColkernel functions to process string values correctly.groupkernel function to handle string values.Test Cases:
group()function in DaphneDSL.