Broadcasting for ewBinary codegen #920
Draft
+81
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the existing ewBinaryOp codegen to broadcast
rhs
if possible.So far, the ewBinary codegen only accepted scalars, matrices of equal shape or combinations of
lhs
being a matrix andrhs
being either a scalar or singleton.Now
rhs
can also be given as a matching (equal tolhs
in one dimension and size1
in the other) row or column vector.An example script (--explain mlir_codegen is optional to show the generated IR):
A more thorough description will be given once some tests have been added.