Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datetimes should be consistent in type #518

Open
dkent600 opened this issue Jul 24, 2020 · 2 comments
Open

datetimes should be consistent in type #518

dkent600 opened this issue Jul 24, 2020 · 2 comments

Comments

@dkent600
Copy link
Contributor

dkent600 commented Jul 24, 2020

Many dates are supplied as Date and many are supplied as Number. This kind of inconsistency can cause all kinds of issues with consuming software (immediate example: daostack/alchemy#1984)

  1. They should all be supplied as either Date or number (Date seems more friendly to me, but number is more agnostic.
  2. They should all be declared consistently in their governing interfaces.
@orenyodfat
Copy link
Contributor

orenyodfat commented Jul 25, 2020

I am good with both .. though agree it should be consistence .
If @jellegerbrandy has nothing against Date so lets do Date.
Please note that a time period should be Number.

@roienatan
Copy link
Contributor

The consistency is very important. I think better to use Date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants