Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps of proposal creation, passed. #2053

Closed
Theylon opened this issue Aug 11, 2020 · 5 comments · Fixed by #2064 or daostack/alchemy_2#9
Closed

Add timestamps of proposal creation, passed. #2053

Theylon opened this issue Aug 11, 2020 · 5 comments · Fixed by #2064 or daostack/alchemy_2#9
Assignees
Labels

Comments

@Theylon
Copy link
Contributor

Theylon commented Aug 11, 2020

"Another UI improvement I would ask for Alchemy is to display the timestamps of when a proposal was created, passed, etc."

This is a request from the DXdao, I think this is a great feature which again, is a low hanging fruit.
IIRC this is a parameter that's accessible directly from the graph.

@orenyodfat
Copy link
Contributor

lets start with 1.0 .

@dkent600
Copy link
Contributor

@Theylon @orenyodfat

  1. In addition to the block time, do you also want to display the execution reason:

QueueBarCrossed, QueueTimeOut, PreBoostedBarCrossed, BoostedTimeOut, BoostedBarCrossed

  1. Just noting again that in arc.js the proposal creation and execution date properties are inconsistent in how they are typed, see datetimes should be consistent in type arc.js#518. But I can work around that.

  2. Besides creation and execution, there are potentially other events we can include. Do you want any of these:

  • ExpirationCallBounty
  • Redeem
  • RedeemReputation
  • RedeemDaoBounty
  • ConfidenceLevelChange
  • StateChange
  • Vote
  • Stake

@Theylon
Copy link
Contributor Author

Theylon commented Aug 16, 2020

Hey sorry, this is an issue requested by John from DXdao,
I would say a timestamp of proposal created and last timestamp of last event, boosted, passed, redeemed

@dkent600
Copy link
Contributor

dkent600 commented Aug 17, 2020

@Theylon Can you please see the PR and reply there whether that is good enough, and if not, specifically what you think it should be? Thanks.

@Theylon
Copy link
Contributor Author

Theylon commented Sep 1, 2020

Hey @dkent600 sorry I was away, yes that looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants