handle all arc.js datetime types #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roienatan
reviewed
Jul 25, 2020
I'm not sure at the moment, would need to research it a bit. May depend on which data type is chosen. May not hurt to keep the change, just to be robust. This line in particular should be checked:
|
roienatan
reviewed
Jul 26, 2020
| @@ -301,7 +301,7 @@ export async function getNetworkId(web3Provider?: Web3Provider): Promise<string> | |||
| return network.chainId.toString(); | |||
| } else { | |||
| const promise = new Promise<string>((resolve, reject) => { | |||
| web3Provider.send("net_version", (error, response) => { | |||
| web3Provider.send("net_version", (error: any, response: any) => { | |||
There was a problem hiding this comment.
it is just the usual typescript lint warning improvements, an ongoing improvement...does not affect execution of the code.
There was a problem hiding this comment.
ok, yes I assume also the boolean in proposalHelpers.ts
roienatan
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1984
safeMoment.