-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stylix: init droid #778
base: master
Are you sure you want to change the base?
stylix: init droid #778
Conversation
Currently, The base16 palette seems fine though, so perhaps the issue is with the My previous solution not using tinted-kitty worked better, but was adopted from the linked template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also adds the
terminal
module which themes the nix-on-droid terminal viaterminal.colors
. Should this actually be a separate target, or astylix/
module likefonts.nix
?
If the terminal.colors
option is specific to nix-on-droid and not expected to be ported to any of our supported platforms (NixOS, Home Manager, or nix-darwin) in the foreseeable future, then it might be better to "hide" it inside /stylix/droid/terminal.nix
.
Sidenote: I have already thought about changing the current /stylix/<PLATFORM>/
and /modules/<MODULE>/<PLATFORM>.nix
platform abstraction. Whether this is actually a good idea should be evaluated once there is a PoC.
Font support is not yet implemented, because the
terminal.font
requires the path to the actual font file. Support may be added in this PR in case a way is found to acquire the correct path.
Can this be deduced by the stylix.fonts.<FONT>.package
values?
Testbeds also weren't added yet because it would probably require emulating an android device.
Do you know if this could be achievable? If not, it should hopefully be fine since we would mostly be re-testing our Home Manager modules.
Currently,
terminal.colors
uses thetinted-kitty
theme. The colors look slightly off though.
Are the generated configuration files the same?
I use this to get the font file: font = pkgs.runCommandNoCC "font" { } ''
cp ${
pkgs.nerdfonts.override { fonts = [ "Terminus" ]; }
}/share/fonts/truetype/NerdFonts/TerminessNerdFontMono-Regular.ttf $out
''; Unsure how to expose it better for the user tho. |
That is indeed the case, so I'll move that functionality!
The font package is a directory containing one or multiple font files anywhere inside of
I don't know, but since there are currently no target applications besides the builtin terminal, I think it wouldn't be worth it.
AFAIK nix-on-droid generates a colors.property file for the underlying Termux terminal. I will check whether the values match the ones of the Kitty config though.
Fonts that aren't nerd fonts might be located in any sub directory of |
Everything looks correct. > cat .termux/colors.properties
background=#1e1e2e
color1=#f38ba8
color10=#181825
color11=#313244
color12=#585b70
color13=#f5e0dc
color14=#f2cdcd
color15=#b4befe
color2=#a6e3a1
color3=#f9e2af
color4=#89b4fa
color5=#cba6f7
color6=#90c0e4
color7=#cdd6f4
color8=#45475a
color9=#fab387
cursor=#cdd6f4
foreground=#cdd6f4 |
Adds support for the nix-on-droid platform. Exposes the nixOnDroidModules.stylix module. Uses a temporary workaround for nix-community/nix-on-droid#436.
Adds theming support for the builtin terminal on nix-on-droid.
Co-authored-by: NAHO <[email protected]>
It's possible to use Lines 13 to 31 in 51ad2ce
For nix-on-droid the conversion step wouldn't be necessary, we can just do something like |
Thank you, that looks perfect! I'll try using that. |
This PR adds nix-on-droid as a new target platform and exposes the
nixOnDroidModules.stylix
module. It uses a temporary workaround for nix-community/nix-on-droid#436 by adding the missingconfig.lib
option. Closes #775.It also adds the
terminal
module which themes the nix-on-droid terminal viaterminal.colors
. Should this actually be a separate target, or astylix/
module likefonts.nix
?Font support is not yet implemented, because the
terminal.font
requires the path to the actual font file. Support may be added in this PR in case a way is found to acquire the correct path.Testbeds also weren't added yet because it would probably require emulating an android device.