firefox: support derivatives #695
Conversation
This also makes the librewolf module obsolete and removes it. This change eliminates redundancy at the cost of slightly less readable code.
There was a problem hiding this comment.
This PR enables the Firefox module to support all programs created by Home Manager's
mkFirefoxModule. This includes all current and future Firefox derivatives supported by Home Manager.This also makes the recently introduced LibreWolf module from #679 obsolete and removes it. This change eliminates redundancy and makes future changes easier at the cost of slightly less readable code.
Great job!
New derivatives can be supported by adding the required details to the
derivativesvariable:Lines 16 to 19 in 2184cd7
Do you mind adding support for all Home Manager supported derivatives? I see that your original PR nix-community/home-manager#5128 mentions more derivatives.
The derivatives listed there were used as a proof of concept and I accidentally closed related PRs by listing them there. Currently, LibreWolf is the only derivative that has been added, but I plan on supporting Floorp and Mullvad Browser as well and will add them to the list then. |
|
Successfully created backport PR for |
Leverage Home Manager's mkFirefoxModule pattern introduced in commit
792757f643ce [1] ("firefox: support firefox derivatives").
[1]: nix-community/home-manager@792757f
Reviewed-by: NAHO <[email protected]>
Tested-by: NAHO <[email protected]>
(cherry picked from commit 079fece)
Leverage Home Manager's mkFirefoxModule pattern introduced in commit
792757f643ce [1] ("firefox: support firefox derivatives").
[1]: nix-community/home-manager@792757f
Reviewed-by: NAHO <[email protected]>
Tested-by: NAHO <[email protected]>
(cherry picked from commit 079fece)
This PR enables the Firefox module to support all programs created by Home Manager's
mkFirefoxModule. This includes all current and future Firefox derivatives supported by Home Manager.This also makes the recently introduced LibreWolf module from #679 obsolete and removes it. This change eliminates redundancy and makes future changes easier at the cost of slightly less readable code.
New derivatives can be supported by adding the required details to the
derivativesvariable:stylix/modules/firefox/hm.nix
Lines 16 to 19 in 2184cd7