Allow floats for font sizes #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueNAHO
requested changes
Dec 22, 2024
There was a problem hiding this comment.
Consider squashing and rewording the following two commits:
Subject: [PATCH 1/3] stylix: use floats for font sizes Subject: [PATCH 3/3] stylix: revert font size defaults to integers
The current patchset successfully builds in my setup:
Tested-by: NAHO <[email protected]>
A hack necessary because of a home-manager limitation. It works because numbers and strings are serialized the same way for .Xresources. It should be reverted after this issue is addressed upstream.
trueNAHO
approved these changes
Dec 22, 2024
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font sizes are currently treated as
pt, so they should allow floating point values in addition to integer values. The documentation is also updated to make this clear.I've done my best to check and adjust affected modules, but I may have missed some so extra eyes would be appreciated.