Further implementation of stylix.imageScalingMode
#678
Conversation
I am not very familiar with the KDE ecosystem. @danth, might be more helpful here.
Consider using testbeds. Note that #612 already adds testbeds for various applications.
The following modules rely on $ rg --files-with-matches stylix\.image modules | sort
modules/feh/hm.nix
modules/feh/nixos.nix
modules/gnome/hm.nix
modules/gnome/nixos.nix
modules/grub/nixos.nix
modules/hyprlock/hm.nix
modules/hyprpaper/hm.nix
modules/i3/hm.nix
modules/kde/hm.nix
modules/lightdm/nixos.nix
modules/regreet/nixos.nix
modules/sway/hm.nix
modules/swaylock/hm.nix
modules/wpaperd/hm.nix |
|
So I can avoid some headaches: does this repo have a standard format/formatter? |
|
The testbed is confusing me--how can I adjust the stylix configuration that's being used in the VM? |
justDeeevin
force-pushed
the
imageScaling-expansion
branch
from
611e976 to
2335d41
Compare
justDeeevin
force-pushed
the
imageScaling-expansion
branch
from
208088b to
3a58f56
Compare
In order to declutter the commit history, avoid formatting changes, as they will be superseded by #519 in the future.
Testbeds are implemented in |
|
For KDE: it doesn't look like a look-and-feel can change the image fill mode...? this is very poorly documented |
|
Apart from KDE, this is ready. |
Co-authored-by: Daniel Thwaites <[email protected]>
|
Anything else? |
Add stylix.imageScalingMode support to all modules except: - hyprlock - hyprpaper - kde - lightdm - sway Closes: #677 Link: #678 Reviewed-by: NAHO <[email protected]> Reviewed-by: Daniel Thwaites <[email protected]> (cherry picked from commit a2d66f2)
|
Successfully created backport PR for |
Add stylix.imageScalingMode support to all modules except: - hyprlock - hyprpaper - kde - lightdm - sway Closes: #677 Link: #678 Reviewed-by: NAHO <[email protected]> Reviewed-by: Daniel Thwaites <[email protected]> (cherry picked from commit a2d66f2)
Fixes #677
Presently,
stylix.imageScalingModeonly has an effect on sway. This PR implements it forIt seems like setting this for KDE isn't possible with our current methods.