Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zed: added zed hm module #620

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

TheYoxy
Copy link

@TheYoxy TheYoxy commented Nov 11, 2024

Add zed editor module support.

Closes: #348

modules/zed/hm.nix Outdated Show resolved Hide resolved
modules/zed/hm.nix Outdated Show resolved Hide resolved
modules/zed/hm.nix Outdated Show resolved Hide resolved
modules/zed/hm.nix Outdated Show resolved Hide resolved
modules/zed/hm.nix Outdated Show resolved Hide resolved
@TheYoxy TheYoxy force-pushed the feature/zed branch 2 times, most recently from c5080ee to 2269bd3 Compare November 12, 2024 10:24
@TheYoxy
Copy link
Author

TheYoxy commented Nov 12, 2024

@trueNAHO I've seen that the current version of home-manager from flake.lock doesn't contains any references to zed-editor yet. Should it be updated from this pr or should I mark this pr as stale waiting from this update ?

@trueNAHO
Copy link
Collaborator

I've seen that the current version of home-manager from flake.lock doesn't contains any references to zed-editor yet. Should it be updated from this pr or should I mark this pr as stale waiting from this update ?

Update /flake.lock in this PR.

flake.lock Outdated Show resolved Hide resolved
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing:

error: attribute 'zed-editor' missing
at /nix/store/g2ia4fjmdkbjrxbrmwhj4q62bysym489-modules/zed/hm.nix:12:82:
    11|
    12|   config = lib.mkIf (config.stylix.enable && config.stylix.targets.zed.enable && config.programs.zed-editor.enable) {
      |                                                                                  ^
    13|     programs.zed-editor.userSettings = {
Error: Process completed with exit code 1.

Maybe the current /flake.lock still does not include the Zed module.

@TheYoxy
Copy link
Author

TheYoxy commented Nov 18, 2024

Yeah, I'll keep it stale until flake.lock is updated with hm version that supports the zed-editor.

@trueNAHO
Copy link
Collaborator

Yeah, I'll keep it stale until flake.lock is updated with hm version that supports the zed-editor.

AFAIK, commit cf5be81 contains the zed-editor module in Home Manager. Consider rebasing on top of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zed: add support
2 participants