Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland: adapt breaking changes #605

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

diniamo
Copy link
Contributor

@diniamo diniamo commented Nov 6, 2024

@danth danth linked an issue Nov 6, 2024 that may be closed by this pull request
Copy link
Owner

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@danth danth merged commit 762c07e into danth:master Nov 6, 2024
10 checks passed
@tfkhdyt
Copy link

tfkhdyt commented Nov 6, 2024

image

This PR causes an issue when using Hyprland from nixpkgs (unstable) which is still in version 0.44.1

@tfkhdyt
Copy link

tfkhdyt commented Nov 6, 2024

image1

This PR causes an issue when using Hyprland from nixpkgs (unstable) which is still in version 0.44.1

image
My workaround is to lock the input flake to the previous commit

@diniamo
Copy link
Contributor Author

diniamo commented Nov 7, 2024

Should have waited for a stable release with the commit before merging this. I forgot to mention that.

trueNAHO added a commit to trueNAHO/stylix that referenced this pull request Nov 7, 2024
Revert commit 762c07e ("hyprland: adapt breaking changes (danth#605)"),
which falsely attempted to address a Hyprland breaking change [1] which
is not yet available as a Hyprland release or Nixpkgs package, and
therefore not available through Stylix's inputs.nixpkgs input.

To address the future breaking change, update Stylix's inputs.nixpkgs
input after the next Hyprland release is included in
nixpkgs/nixos-unstable.

[1]: hyprwm/Hyprland@d1638a0

Link: danth#608
@trueNAHO
Copy link
Collaborator

trueNAHO commented Nov 7, 2024

My workaround is to lock the input flake to the previous commit

Considering that it will take a while for the mentioned Hyprland commit to reach nixpkgs/nixos-unstable, I have reverted this PR in #608.

@diniamo
Copy link
Contributor Author

diniamo commented Nov 7, 2024

FWIW, there is a Hyprland release coming in a few days.

trueNAHO added a commit that referenced this pull request Nov 7, 2024
…nge (#608)

Revert commit 762c07e ("hyprland: adapt breaking changes (#605)"),
which falsely attempted to address a Hyprland breaking change [1] which
is not yet available as a Hyprland release or Nixpkgs package, and
therefore not available through Stylix's inputs.nixpkgs input.

To address the future breaking change, update Stylix's inputs.nixpkgs
input after the next Hyprland release is included in
nixpkgs/nixos-unstable.

[1]: hyprwm/Hyprland@d1638a0

Link: #608
@trueNAHO
Copy link
Collaborator

trueNAHO commented Nov 7, 2024

FWIW, there is a Hyprland release coming in a few days.

IIRC, Vaxry's Hyprland release schedule is not periodic, making it somewhat unreliable to wait on its next release.

Either way, #608 has been merged.

@diniamo
Copy link
Contributor Author

diniamo commented Nov 7, 2024

I know, he specifically said so in the Discord. I'm not making things up.

@DaRacci
Copy link

DaRacci commented Nov 8, 2024

since some people (admittedly probably not too many) do follow the latest master commits maybe it would be worth having a staging branch for stylix that can apply fixes like these before they would appear in nixpkgs?

@diniamo
Copy link
Contributor Author

diniamo commented Nov 8, 2024

You can always use my branch, I'll make a take 2 draft PR so it's easier to find. #610

@trueNAHO
Copy link
Collaborator

trueNAHO commented Nov 8, 2024

since some people (admittedly probably not too many) do follow the latest master commits maybe it would be worth having a staging branch for stylix that can apply fixes like these before they would appear in nixpkgs?

Mixing nixpkgs/nixos-unstable and hyprland/master could be done by declaring a different config in /modules/hyprland/hm.nix depending on an added inputs.hyprland Stylix input, pointing to hyprland/master.

mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 17, 2024
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 17, 2024
…nge (danth#608)

Revert commit 762c07e ("hyprland: adapt breaking changes (danth#605)"),
which falsely attempted to address a Hyprland breaking change [1] which
is not yet available as a Hyprland release or Nixpkgs package, and
therefore not available through Stylix's inputs.nixpkgs input.

To address the future breaking change, update Stylix's inputs.nixpkgs
input after the next Hyprland release is included in
nixpkgs/nixos-unstable.

[1]: hyprwm/Hyprland@d1638a0

Link: danth#608
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 20, 2024
mateusauler pushed a commit to mateusauler/stylix that referenced this pull request Nov 20, 2024
…nge (danth#608)

Revert commit 762c07e ("hyprland: adapt breaking changes (danth#605)"),
which falsely attempted to address a Hyprland breaking change [1] which
is not yet available as a Hyprland release or Nixpkgs package, and
therefore not available through Stylix's inputs.nixpkgs input.

To address the future breaking change, update Stylix's inputs.nixpkgs
input after the next Hyprland release is included in
nixpkgs/nixos-unstable.

[1]: hyprwm/Hyprland@d1638a0

Link: danth#608
willbush added a commit to willbush/system that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: hyprland changed shadow config
5 participants