zellij: fix black & white #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings the Zellij theme more in-line with the default theme. For dark themes, Zellij's shades go from darkest to brightest: black < bg < fg < white. The exact shades used for the four is based on the standard mapping of the 8 primary colors to ANSI's 4 shades. This makes the tab and status bars significantly more readable. This does not account for light themes, and Zellij dynamically switches between white and black for certain elements depending on the polarity, however I couldn't find of other modules that accounted for polarity, so I left it for a future change. I also did not rename the accents to their semantic names, though it would be simple to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the Zellij theme more in-line with the default theme. For dark themes, Zellij's shades go from darkest to brightest: black < bg < fg < white. The exact shades used for the four is based on the standard mapping of the 8 primary colors to ANSI's 4 shades.
This makes the tab and status bars significantly more readable.
This does not account for light themes, and Zellij dynamically switches between white and black for certain elements depending on the polarity, however I couldn't find of other modules that accounted for polarity, so I left it for a future change. I also did not rename the accents to their semantic names, though it would be simple to do.