-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kde: apply Qt theme on non-KDE systems and add Qt6 support #367
Conversation
It worked with PCManFM-Qt when I tried it, so it works with some. What apps was it not working for? |
You're right, it works straight away with PCManFM. I just tried some XFCE apps and they work, too. I was trying it with KeepassXC before, which does include its own theming menu, so it may just be that KeepassXC is doing its own thing even when I set it to use the system theme. |
If you set keepassxc to use the "Classic (platform native)" theme it should follow your system theme |
I tried that, but it kept a default white theme for some reason. |
Side note: This PR adds around 250 MiB downloaded and 800 MiB unpacked on a GNOME system, due to the dependency on |
Interesting - works fine on my machine. I think there'll always be some strange edge cases with how weird Qt theming is in general - probably best to deal with these cases as they come up. |
We could try and remove the plasma-workspace dependency if it becomes a problem that people complain about by trying to write to |
In it's current iteration, this PR doesn't seem to work if |
I've edited the PR to replace the dependency on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using kdeglobals
rather than a look and feel package makes the user experience worse when KDE is used, since the settings menu no longer shows that it's using a Stylix theme.
Perhaps we can use environment variables to force plasma-apply-lookandfeel
to find the package in all situations?
* Testing * Testing * Testing * Testing * Testing
My Templates does contain a lot of pywal based templates but they are not in |
|
@Jackaed https://github.com/dzervas/dotfiles/tree/f2b784c3ef018b7693861140d8250bbbef3fdeb9 only the |
The issue is that this did not previously have qt6 support, which it now does. You were using dolphin qt6 because you were using |
Okay, after a lot of meddling, this now works with Qt6 everything (at least on my system, please test independently). |
Yeah icons were a pain in the arse, installing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my system too, as well as in the testbed VM - where KDE theming no longer requires any manual steps to apply.
Although this isn't a perfect solution:
- It makes
kdeglobals
read-only, which I believe may cause issues with a small number of programs - It installs several potentially large packages
It's a huge improvement over the current situation, and I'm happy to merge this now.
Fixes plasma theme not applying on non-KDE desktop environments and on window managers. See #142.