Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freecad: add support #264

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

freecad: add support #264

wants to merge 2 commits into from

Conversation

RANKSHANK
Copy link
Contributor

@RANKSHANK RANKSHANK commented Feb 25, 2024

Adds support for FreeCAD

screenshot_18:29:30_25February2024
base16/gruvbox-dark-hard

screenshot_18:32:16_25February2024
base16/catppuccin-latte

Works by generating a preference pack with a config file and a qss stylesheet that match the theme. This means users will need to select pack in FreeCAD's preferences menu. Changes will also only propagate after either cycling packs or restarting FreeCAD.

There are a lot of components getting themed here, many of which I've just 'best guessed' at for the first pass, so I'm opening this as a draft for input whilst I'm dog-fooding the changes.

Current Todo List:

  • Script/Macro editor implementation
  • Disable the preference pack's generation when FreeCAD is not installed
  • Investigate lightmode's color implementation
  • Add an icon to the preference pack
  • Migrate xml to nix generators
  • General polish

Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using builtins.toXML, if it is beneficial.

@trueNAHO trueNAHO changed the title Added FreeCAD Support freecad: add support Feb 26, 2024
@RANKSHANK
Copy link
Contributor Author

Good point, added to the todo list, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants