Reduce duplication in stylix #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalil-salame
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Looks good to me. It also looks easy to adapt #201 to support this c:
|
Maybe we can wait for #201 to be merged, and I'll update this PR at that point. |
This looks easier to review and merge than my PR. |
jalil-salame
added a commit
to jalil-salame/stylix
that referenced
this pull request
Feb 9, 2024
jalil-salame
added a commit
to jalil-salame/stylix
that referenced
this pull request
Feb 16, 2024
jalil-salame
added a commit
to jalil-salame/stylix
that referenced
this pull request
Mar 16, 2024
jalil-salame
added a commit
to jalil-salame/stylix
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dudplication in
stylix/*/fonts.nixandstylix/*/palette.nix.I haven't tested on macos, so if someone could test it there that would be great.
Fixes #234