Optimize getTexture func #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor optimization updates
+ Caches result of Object.keys() for increased performance + Strips unused items from search pool and caches the result Now provides ~40% boost for static and a ~100% boost for more optimized implementations. (For the parseEconItem function)
|
Performance has been further increased to 40% boost for static and 100% boost for further optimizations. The previous tip about filtering out unused entries in the search space has been integrated directly within getTexture. |
|
I'm not against this but it cannot use the global scope for caching, since you can inject your own schema and texture's can differ. |
|
Although it's less than ideal, would it be feasble to actually cache in the injected Schema? I can see a potential problem arising with collisions between the property used for caching and whatever the injected Schema uses |
|
I don't want to introduce any breaking changes as of currently, so this improvement will need to wait until rewrite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to execution order, results in about 5% extra performance with static and 20% extra performance if further optimized through ISchema.