Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔃 fix: Exclude OAuth Routes From Service Worker Navigation #4956

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

thelinuxkid
Copy link
Contributor

@thelinuxkid thelinuxkid commented Dec 12, 2024

Pull Request Template

⚠️ Before Submitting a PR, Please Review:

  • Please ensure that you have thoroughly read and understood the Contributing Docs before submitting your Pull Request.

⚠️ Documentation Updates Notice:

  • Kindly note that documentation updates are managed in this repository: librechat.ai

Summary

Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Translation update

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Before the fix the redirect was split into two by the Service Worker and the page showed a 404

image

After the fix the redirect was done correctly and the page was redirected properly

image

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@thelinuxkid thelinuxkid marked this pull request as ready for review December 12, 2024 06:54
@danny-avila danny-avila changed the title Oauth fix 🔃 fix: Exclude OAuth Routes From Service Worker Navigation Dec 12, 2024
@danny-avila danny-avila merged commit 6f9bbba into danny-avila:main Dec 12, 2024
2 checks passed
Tsounguinzo pushed a commit to Tsounguinzo/LibreChat that referenced this pull request Dec 14, 2024
owengo pushed a commit to openwengo/LibreChat that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants