-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support setting image_size=(width, height) #45
base: master
Are you sure you want to change the base?
Conversation
Did you verify that it still passes the existing test cases? I cannot test it myself for the next few days. |
Even daniilidis-group/neural_renderer branch itself cannot pass the test cases. |
fix a bug in orig_size I wrote, which is not tested in testcase lol |
Sorry for not being very responsive. What is the status of this PR? |
I believe it works (because I am using it now), but not exactly sure. |
From a quick look it doesn't not break backwards compatibility. I will try to write some small unit tests, and if it passes I will merge it. |
FWIW I think I've done some basic fixing of unittests in #115 (well, relaxing the failing mask intersections at least) |
No description provided.