Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions not supporting latest macOS SDK and runner #114

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

DominikBucher12
Copy link
Collaborator

@DominikBucher12 DominikBucher12 commented Jan 12, 2024

What this PR do:

  • Aligns Preview for RichTextColor Picker to use old Preview structure.
  • Updates Build action to use for now only iOS build and test
  • MacOS will be added in separate PR in order for all PRs to be merged (and taken care of)

Why no1

  1. Unified Previews system
  2. No compilation errors on newer systems
  3. When unified with others, we can easily change this in future

Why no2

  • Green builds
  • Testing at last on each PR at least for iOS
  • CI is awesome.

@danielsaidi
Copy link
Owner

Ok, let's revert :)

But I think you have to run swiftformat

@danielsaidi
Copy link
Owner

@DominikBucher12 Reverting this will not fix the test runner, unless you've adjusted the script to correctly use Xcode 15? I use some return omits that require Xcode 15.

@DominikBucher12
Copy link
Collaborator Author

I am taking a look to adjust the script, funny enough, on both of my machines (Xcode 15 and 15.2) everything compiles fine, do you know root cause of this?

@DominikBucher12 DominikBucher12 force-pushed the fix/previews branch 4 times, most recently from 875d2f8 to 6ac7b8b Compare January 12, 2024 15:07
@DominikBucher12 DominikBucher12 changed the title [FIX] Change preview Fix GitHub Actions not supporting latest macOS Jan 12, 2024
@DominikBucher12
Copy link
Collaborator Author

Holly Jolly Green as they say ✅

@DominikBucher12 DominikBucher12 changed the title Fix GitHub Actions not supporting latest macOS Fix GitHub Actions not supporting latest macOS ADK and runner Jan 12, 2024
@DominikBucher12 DominikBucher12 changed the title Fix GitHub Actions not supporting latest macOS ADK and runner Fix GitHub Actions not supporting latest macOS SDK and runner Jan 12, 2024
Copy link
Owner

@danielsaidi danielsaidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Dominik!

@danielsaidi danielsaidi merged commit 2a20a94 into danielsaidi:main Jan 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants