-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn on hvac when setting temp (if hvac is off) #40
turn on hvac when setting temp (if hvac is off) #40
Conversation
Signed-off-by: Dusan <[email protected]>
Signed-off-by: Dusan <[email protected]>
Signed-off-by: Dusan <[email protected]>
Signed-off-by: Dusan <[email protected]>
Like the config options, I think that alleviates my primary concern with this type of behavior change. However, I'm currently struggling to install your branch. I think HACS 2.0 broke the ability to specify branches, if you can change the default branch of your fork to your changes I think it will get picked up? Alternatively, open to other approaches for how to get HACS to respond well to your fork, I meanwhile have raised hacs/integration#4203 |
I made merged this feature branch with my main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, tried it out. Just a small nit on language and I'll merge it in
Signed-off-by: Dusan <[email protected]>
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
For UI perspective this makes sense to me. If you set the temperature, HVAC should turn on if it isn't on already.
I'm not sure if there are any concerns to make this the default behavior?
Could resolve this: #36