Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on hvac when setting temp (if hvac is off) #40

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

uvera
Copy link
Contributor

@uvera uvera commented Nov 13, 2024

For UI perspective this makes sense to me. If you set the temperature, HVAC should turn on if it isn't on already.
I'm not sure if there are any concerns to make this the default behavior?

Could resolve this: #36

@ohshazbot
Copy link
Collaborator

Like the config options, I think that alleviates my primary concern with this type of behavior change.

However, I'm currently struggling to install your branch. I think HACS 2.0 broke the ability to specify branches, if you can change the default branch of your fork to your changes I think it will get picked up? Alternatively, open to other approaches for how to get HACS to respond well to your fork, I meanwhile have raised hacs/integration#4203

@uvera
Copy link
Contributor Author

uvera commented Nov 17, 2024

Like the config options, I think that alleviates my primary concern with this type of behavior change.

However, I'm currently struggling to install your branch. I think HACS 2.0 broke the ability to specify branches, if you can change the default branch of your fork to your changes I think it will get picked up? Alternatively, open to other approaches for how to get HACS to respond well to your fork, I meanwhile have raised hacs/integration#4203

I made merged this feature branch with my main branch

https://github.com/uvera/ha_airstage/commits/main/

Copy link
Collaborator

@ohshazbot ohshazbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tried it out. Just a small nit on language and I'll merge it in

custom_components/fujitsu_airstage/translations/en.json Outdated Show resolved Hide resolved
@uvera uvera requested a review from ohshazbot November 18, 2024 08:11
@ohshazbot ohshazbot merged commit 811a8c8 into danielkaldheim:main Nov 18, 2024
@danielkaldheim
Copy link
Owner

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants