Warn and relax global j1939 if non-extended IDs present #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a DBC file containing one message with non-extended ID.
asammdf refused to accept that and threw an exception even if the rest of the file was OK.
I think warning in this case may be a less drastic approach - the suggested change allows me
to run without modifying either asammdf locally or my incoming data, while still passing the tests.
Speaking of tests - it seems to me that running the GUI tests on a large screen (3840 x 2160)
places the gui window in the lower right part of the screen, but it seems the cursor is placed farther
and farther to "north-west", ie up and left - and after a while leaving the window which stops the
test sequence. Manually moving it back makes tests continue, but the behaviour is repeated,
Running on a "standard" sized screen does not seem to behave like this.