Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cleanup and fix issues #1097

Merged

Conversation

JulienGrv
Copy link
Contributor

@JulienGrv JulienGrv commented Nov 16, 2024

What has been done:

  • update GitHub actions
  • use editable install, requirements are placed in the setup.py and it is not required to repeat them anywhere else
  • use python -m build in place of the deprecated python setup.py
  • shell snippets are POSIX compliant now
  • update pre-commit hooks
  • remove version: 3.8 in .readthedocs.yml because it does not work
  • add VSCode recommended extensions to work on the project
  • add developer instructions in CONTRIBUTING.md
  • update README.md
  • format markdown, yaml and toml files
  • remove deprecated setup.cfg, pylint.cfg and pre_commit.bat
  • align ruff and black settings between direct usage and pre-commit usage
  • always install decode and export extra dependencies for gui extra
  • fix issue where python builtins were deleted and overriden, which caused python internals to fail when looking for the eval function. Unfortunately, fixing this issue introduced another one for the gui. However, as a general rule of thumb, we should not mess with python builtins or else we can break python itself. Hopefully we can find a better implementation in the future.
  • remove fastpath argument to pandas Series as it is long deprecated and causes warnings when running pytest
  • tox.ini settings are simplified as well thanks to new canonical requirements.txt files and gui extras installation

@JulienGrv JulienGrv force-pushed the feature/cleanup-and-fix-issues branch 2 times, most recently from 572ca4b to 2da6ee2 Compare November 17, 2024 23:05
src/asammdf/mdf.py Outdated Show resolved Hide resolved
@JulienGrv JulienGrv force-pushed the feature/cleanup-and-fix-issues branch from 2da6ee2 to 4753837 Compare November 18, 2024 21:06
@danielhrisca
Copy link
Owner

Let me know when it is ready

@JulienGrv JulienGrv force-pushed the feature/cleanup-and-fix-issues branch 2 times, most recently from b1ca22f to 69a0be0 Compare November 18, 2024 21:44
@JulienGrv JulienGrv force-pushed the feature/cleanup-and-fix-issues branch from 69a0be0 to f39b1ab Compare November 18, 2024 21:53
@JulienGrv JulienGrv marked this pull request as ready for review November 18, 2024 22:28
@JulienGrv
Copy link
Contributor Author

JulienGrv commented Nov 18, 2024

Hi @danielhrisca , it's ready now. However there is still issues in the CI tests that need to be fixed but the situation is slightly improved with this PR. I have listed what has been done in this PR. Good luck fixing the issues with numpy 2.0!

@danielhrisca danielhrisca merged commit 779f31b into danielhrisca:development Nov 19, 2024
12 of 23 checks passed
@danielhrisca
Copy link
Owner

thank you Julien!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants