Fix sending of workflow completed event #1201
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
As described in #1097 a workflow that ends in an
EndStep
does not lead to theWorkflowCompleted
LifeCycleEvent
being published becauseDetermineNextExecutionTime
returns too early.This PR remedies that by sending the event also in case of an early return from
DetermineNextExecutionTime
.Describe your implementation or design
Extracted publishing of
WorkflowCompleted
into a separate method and added a call to that function before the early return if workflow is completed.Tests
Yes, added a failing unit test that is green after the implementation is changed.
Breaking change
No
Additional context