Remove CancellationToken from writing persistence operations #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamidenn
force-pushed
the
fix-race-condition-on-stop
branch
3 times, most recently
from
67af11f to
78b5828
Compare
If the host is stopped as soon as WorkflowCompleted LifeCycleEvent is raised, some persistence providers cannot persist the 'Completed' state in time.
Writing persistence operations can no longer be cancelled to prevent data loss when cancelling a workflow. Fixes danielgerlag#953, danielgerlag#1032
mamidenn
force-pushed
the
fix-race-condition-on-stop
branch
from
78b5828 to
c92d06b
Compare
|
Here is an alternative, less invasive approach: |
Yes, I like this approach better ^ |
Closing this in favor of #1081 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Removed the
CancellationTokenparameter from all writing persistence operations. This prevents cancelling workflows or stopping the host from cancelling writing persistence operations and thus losing data.Fixes #953
Fixes #1032
Describe your implementation or design
Removed the
CancellationTokenparameter from all writing persistence operations.Tests
Yes. I reproduced the issue by adding a
StopScenariofor persistence providers. After the change, this scenario passes.Breaking change
Yes. Removed
CancellationTokenparameter from multiple public methods.