Correction #1
Open
Correction #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjvilloud
commented
Mar 12, 2019
| try { | ||
| return Double.parseDouble(monDouble); | ||
| } catch (NumberFormatException e) { | ||
| if (index == 4) |
There was a problem hiding this comment.
Je te conseille de mettre les {} même s'il n'y a qu'une instruction
| try { | ||
| return Integer.parseInt(monInteger); | ||
| } catch (NumberFormatException e) { | ||
| if (index == 5) |
There was a problem hiding this comment.
Je suis pas fan de cette méthode avec des if pour traiter les différents cas, car si tu rajoutes un Integer dans ta ligne, tes index seront potentiellement différents...
private Integer StringToInteger(String valeur, String, propriete) throws BatchException {
try {
return Integer.parseInt(valeur);
} catch (NumberFormatException e) {
throw new BatchException("La propriété " + propriete + " incorrecte : "+valeur+" => "+ligne);
}
}| * @param ligne | ||
| * @throws BatchException | ||
| */ | ||
| private void checkManager(String ligne) throws BatchException { |
There was a problem hiding this comment.
OK pour ça, une méthode plus simple consiste à maintenir une liste de String contenant les matricules des managers contenus dans le fichier en ajoutant chaque matricule du manager au fur et à mesure de la lecture du fichier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(en cours)