Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually define max_wavelength (and min) while creating spectral_data object #8

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented May 20, 2024

Describe your changes
actually define max_wavelength (and min) while creating spectral_data object within plantcv.geospatial.read_geotif. This attribute is checked while calculating indices, so add min & max to just find the min/max wavelength item available in the dictionary after it's been created.

Type of update
Is this a:

  • feature enhancement

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl self-assigned this May 20, 2024
Copy link

deepsource-io bot commented May 20, 2024

Here's the code health analysis summary for commits e82daa2..2c40a12. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@HaleySchuhl HaleySchuhl added enhancement New feature or request ready to review labels May 20, 2024
Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@k034b363 k034b363 merged commit 6723266 into main Aug 28, 2024
5 checks passed
@k034b363 k034b363 deleted the add_min_max_wavelength branch August 28, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants