Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicked points to shape file #23

Merged
merged 18 commits into from
Nov 6, 2024
Merged

Clicked points to shape file #23

merged 18 commits into from
Nov 6, 2024

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented Oct 4, 2024

Describe your changes
This PR adds a function that takes a napari viewer with a points layer or a pcv.annotate points class object and saves the clicked points as a geojson. This would replace our current clicking in QGIS method.

Type of update

  • New feature or feature enhancement

Associated issues
Would close #22

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv-geospatial/mkdocs.yml
  • Changes to function input/output signatures added to changelog.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 linked an issue Oct 4, 2024 that may be closed by this pull request
Copy link

deepsource-io bot commented Oct 4, 2024

Here's the code health analysis summary for commits bc7a157..b6aa5ef. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@k034b363 k034b363 added enhancement New feature or request Work in Progress labels Oct 11, 2024
@HaleySchuhl HaleySchuhl merged commit c9052db into main Nov 6, 2024
5 checks passed
@HaleySchuhl HaleySchuhl deleted the 22-clicks-to-shapefile branch November 6, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use plantcv-annotate to turn clicks into a shape file
2 participants