Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform points #14

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Fix transform points #14

merged 4 commits into from
Sep 20, 2024

Conversation

k034b363
Copy link
Contributor

@k034b363 k034b363 commented Sep 9, 2024

Describe your changes
After transform.points was merged, it was discovered that for long geojson files, enumerate behaves incorrectly and only some of the file lines get read. This PR changes the logic to fix this problem.

Type of update
Is this a:

  • Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Copy link

deepsource-io bot commented Sep 9, 2024

Here's the code health analysis summary for commits 155fc39..9503653. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Your fix of updating the transformation metadata in the code where cropto is applied in read_geotif works nicely, so that update is included.

@HaleySchuhl HaleySchuhl merged commit bc7a157 into main Sep 20, 2024
5 checks passed
@HaleySchuhl HaleySchuhl deleted the fix_tranform_points branch September 20, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants