Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more detailed LinkML validation errors #13

Merged
merged 13 commits into from
Oct 23, 2024

Conversation

candleindark
Copy link
Member

@candleindark candleindark commented Oct 9, 2024

This PR enables more detailed LinkML validation error info in the generated validation reports with the following features.

  1. Precise locations of the cause of the error both in the data instance and schema.
  2. Validator and validator value in causing the error

Note: This PR is based on the changes made in linkml/linkml#2363. linkml/linkml#2363 has been approved. Ideally, we should merge this PR after linkml/linkml#2363 has been merged to LinkML's main branch.

TODOs:

  • Include the locations, in the data instance and schema, of the cause of a validation error in the validation reports
  • Include validator and validator value in the reports

@candleindark candleindark marked this pull request as ready for review October 14, 2024 17:38
@candleindark
Copy link
Member Author

This PR is ready to merge but to wait for linkml/linkml#2363 to be merged to LinkML:main.

…ErrsType`

This will eliminate code duplications
@candleindark candleindark marked this pull request as ready for review October 23, 2024 00:26
@candleindark
Copy link
Member Author

This PR is ready to merge but to wait for linkml/linkml#2363 to be merged to LinkML:main.

https://github.com/dandi/pydantic2linkml now has a custom linkml dependency, there is no need to wait.

@candleindark candleindark merged commit 706cfa6 into dandi:main Oct 23, 2024
4 checks passed
@candleindark candleindark deleted the detailed-validation-errors branch October 23, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant