-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide more detailed LinkML validation errors #13
Merged
candleindark
merged 13 commits into
dandi:main
from
candleindark:detailed-validation-errors
Oct 23, 2024
Merged
Provide more detailed LinkML validation errors #13
candleindark
merged 13 commits into
dandi:main
from
candleindark:detailed-validation-errors
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only trimming but ensuring the `source` field is available for serialization
…orView` This two values can be used to categorize the errors
This allows the viewing of the error message from the JSON schema validator
This PR is ready to merge but to wait for linkml/linkml#2363 to be merged to LinkML:main. |
…ErrsType` This will eliminate code duplications
candleindark
force-pushed
the
detailed-validation-errors
branch
from
October 18, 2024 02:25
59834ff
to
e8c397a
Compare
https://github.com/dandi/pydantic2linkml now has a custom linkml dependency, there is no need to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables more detailed LinkML validation error info in the generated validation reports with the following features.
Note: This PR is based on the changes made in linkml/linkml#2363. linkml/linkml#2363 has been approved. Ideally, we should merge this PR after linkml/linkml#2363 has been merged to LinkML's main branch.
TODOs: