Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for detection and addition of ome/ngff "standard" into assets summary #252

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Aug 30, 2024

TODOs

  • test

we will need to release so that dandi-archive could take advantage of it

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.64%. Comparing base (d3cc4b4) to head (f82c121).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
dandischema/metadata.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   97.58%   97.64%   +0.06%     
==========================================
  Files          16       16              
  Lines        1739     1744       +5     
==========================================
+ Hits         1697     1703       +6     
+ Misses         42       41       -1     
Flag Coverage Δ
unittests 97.64% <88.88%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandischema/models.py Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member Author

cli fail unrelated

=========================== short test summary info ============================
FAILED tests/test_dandiarchive.py::test_parse_api_url[https://gui.dandiarchive.org/#/dandiset/000001-parsed_url0] - requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
= 1 failed, 706 passed, 1 skipped, 7 xfailed, 9 xpassed, 26 warnings in 720.33s (0:12:00) =
Error: Process completed with exit code 1.

Let's proceed.

@yarikoptic yarikoptic merged commit 4b17876 into master Nov 4, 2024
62 of 64 checks passed
@yarikoptic yarikoptic deleted the enh-ngff branch November 4, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants