Test against PR in dandi-cli to be compatible with pydantic v2 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that dandi-schema is only pydantic 2.0 compatible, and while we are awaiting on dandi-archive to get ready -- there is probably no point to test against released/master dandi-cli -- just makes CI red hiding possible other fails. We need to test against the dandi-cli in that PR for now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 16 16
Lines 1669 1669
=======================================
Hits 1628 1628
Misses 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jwodder
requested changes
Feb 7, 2024
|
no longer needed AFAIK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that dandi-schema is only pydantic 2.0 compatible, and while we are awaiting on dandi-archive to get ready -- there is probably no point to test against released/master dandi-cli -- just makes CI red hiding possible other fails.
We need to test against the dandi-cli in that PR for now