Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __all__ to __init__.py #195

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Add __all__ to __init__.py #195

merged 1 commit into from
Nov 9, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 9, 2023

Because all of the items in the __init__.py namespace are imported from other modules, if a user of dandischema imports or references these items via the top-level dandischema module and they have mypy configured with implicit_reexport = False, then mypy will produce an error. In order to fix this, we need to tell mypy that the items imported into __init__.py are intended for re-export via the __all__ variable.

@jwodder jwodder added the patch Increment the patch version when merged label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7f2245) 97.61% compared to head (74334d2) 97.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          17       17           
  Lines        1758     1759    +1     
=======================================
+ Hits         1716     1717    +1     
  Misses         42       42           
Flag Coverage Δ
unittests 97.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dandischema/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit c674cd6 into master Nov 9, 2023
73 of 75 checks passed
@yarikoptic yarikoptic deleted the all branch November 9, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants