Skip to content

Commit

Permalink
Test against PR in dandi-cli to be compatible with pydantic v2
Browse files Browse the repository at this point in the history
Now that dandi-schema is only pydantic 2.0 compatible, and while we are awaiting
on dandi-archive to get ready -- there is probably no point to test against
released/master dandi-cli -- just makes CI red hiding possible other fails.

We need to test against the dandi-cli in that PR for now
  • Loading branch information
yarikoptic committed Feb 7, 2024
1 parent d8213bb commit a5799a8
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/test-dandi-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ jobs:
# - '3.10'
# - '3.11'
version:
- master
- release
# TEMP: we know those would fail since dandi-cli is not yet pydantic 2.0 compatible
# - master
# - release
- pydantic2
mode:
- normal
include:
Expand Down Expand Up @@ -75,6 +77,10 @@ jobs:
if: ${{ matrix.version == 'release' }}
run: pip install "dandi[test,extras]"

- name: Install dev dandi https://github.com/dandi/dandi-cli/tree/gh-1352 from https://github.com/dandi/dandi-cli/pull/1381
if: ${{ matrix.dandi-version == 'pydantic2' }}
run: pip install "dandi[test,extras] @ git+https://github.com/dandi/dandi-cli@gh-1352"

- name: Set DANDI_DEVEL=1
if: matrix.mode == 'dandi-devel'
run: echo DANDI_DEVEL=1 >> "$GITHUB_ENV"
Expand Down

0 comments on commit a5799a8

Please sign in to comment.